Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not autoplay if no source defined #2127

Closed
wants to merge 3 commits into from

Conversation

bc-bbay
Copy link
Contributor

@bc-bbay bc-bbay commented May 6, 2015

No description provided.

@@ -76,7 +76,7 @@ vjs.Html5 = vjs.MediaTechController.extend({
// In Chrome (15), if you have autoplay + a poster + no controls, the video gets hidden (but audio plays)
// This fixes both issues. Need to wait for API, so it updates displays correctly
player.ready(function(){
if (this.tag && this.options_['autoplay'] && this.paused()) {
if (this.src && this.tag && this.options_['autoplay'] && this.paused()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this.src is a function (getter/setter) not a property, so this should be this.src()

@bclwhitaker
Copy link
Contributor

LGTM

heff pushed a commit to heff/video.js that referenced this pull request May 13, 2015
@dmlap
Copy link
Member

dmlap commented May 19, 2015

Merged via 652a440

@dmlap dmlap closed this May 19, 2015
@bc-bbay bc-bbay deleted the no-source-no-play branch May 19, 2015 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants