Removed all the CDN logic #2230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -27,6 +27,7 @@ | |||
| "lodash-compat": "^3.9.3", | |||
| "object.assign": "^2.0.1", | |||
| "safe-json-parse": "^4.0.0", | |||
| "videojs-font": "1.1.0", | |||
There was a problem hiding this comment.
Did you mean to make this a strict requirement? We should relax this so it will pull the most recent version.
There was a problem hiding this comment.
I originally locked it down as a convenience for the CDN stuff, but we talked offline and decided to lock it down for better reasons.
- We want to be able to call out specific font changes in the video.js change log, or at least have the option to.
- At the CDN level we can't use the auto-updating font because we also base64 encode fonts into the CSS, so the versions would get mismatched. Also the CDN has to point to a specific hosted version of the font, so it needs some way to know the specific font version that was used. It can't get that from a flexible version number.
There was a problem hiding this comment.
Also, should we be more careful with the compiled dependencies? Lodash I feel safe enough with, but for the others the carat feels pretty trusting of the other project authors and npm to not make any mistakes.
heff
force-pushed
the
remove-cdn
branch
4 times, most recently
from
487af3b
to
2725ac5
Compare
|
lgtm |
|
(travis failure was |
See videojs/cdn#3 - Added a guide note about skipping analytics tracking on the CDN - Updated videojs-font - Added videojs-ie8 as a dependency - Updated the examples directory URLs and added to dist - Updated CSS to override font path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And moved it into videojs/cdn#3
closes #2159