Expose vjs xhr #2321
Expose vjs xhr #2321
Conversation
|
Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED Commit: e45e763 (Please note that this is a fully automated comment.) |
|
I believe this build is another victim of the issue fixed in #2316 |
|
Yep. |
|
Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED Commit: 8559a17 (Please note that this is a fully automated comment.) |
|
@heff based on the lack of timeout information, I've re-opened this PR. I think it's worth deferring the change to Raynos/xhr to a later version of video.js since it's not a drop-in right now. |
|
Tests passed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED Commit: 546d01110571272b3892458c828fe15666a2d5af (Please note that this is a fully automated comment.) |
|
Tests passed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED Commit: 70f038392a64812471a0a2074d059742ffedd28e (Please note that this is a fully automated comment.) |
|
Fixes #2387 |
While we wait for Raynos/xhr to allow for downstream testing, expose our own XHR shim. An alternative to videojs#2318.
Assign the merged defaults back to the options object for the xhr helper.
|
While we wait to hear the direction Raynos/xhr is planning on taking with XHR timeouts, we'll continue using our hand-rolled XHR. Hopefully we can replace it before the official 5.0 release. |
|
Tests passed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED Commit: 964683e (Please note that this is a fully automated comment.) |
While we wait for Raynos/xhr to allow for downstream testing, expose our own XHR shim. An alternative to #2318.