Create an error setter on the base tech #2517
Conversation
|
Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED Commit: b5925b5c15694122e8a5c36523872d0e3a35d341 (Please note that this is a fully automated comment.) |
| } | ||
|
|
||
| // trigger a custom error | ||
| tech.error('FLASH: ' + err); |
There was a problem hiding this comment.
possible change
let error = 'FLASH: ' + err;
if (err === 'srcnotfound') {
error = 4;
}
tech.error(error);
|
LGTM. |
Requires videojs/video.js#2517. The HTML implementation should support endOfStream errors natively.
| @@ -11,6 +11,7 @@ import * as Url from '../utils/url.js'; | |||
| import { createTimeRange } from '../utils/time-ranges.js'; | |||
| import FlashRtmpDecorator from './flash-rtmp'; | |||
| import Component from '../component'; | |||
| import MediaError from '../media-error.js'; | |||
There was a problem hiding this comment.
This doesn't appear to be used anywhere.
|
A few notes but otherwise looks good to me. |
Source Handlers may need to trigger player errors if they encounter unrecoverable playback issues. Provide a base implementation of an error setter they can use to do so at the tech level. The setter is overridden for HTML since Source Handlers should probably use something like MediaSource.endOfStream('network') to signal errors in that case. Update Flash error handling to take advantage of the new mechanism.
|
Tests passed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED Commit: 4ad58a2 (Please note that this is a fully automated comment.) |
For #2323. Source Handlers may need to trigger player errors if they encounter unrecoverable playback issues. Provide a base implementation of an error setter they can use to do so at the tech level. The setter is overridden for HTML since Source Handlers should probably use something like MediaSource.endOfStream('network') to signal errors in that case. Update Flash error handling to take advantage of the new mechanism.
Pull in @gkatsev's improvements to Flash error handling in #2515