Fixed displaying the LIVE control bar item #2551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm (update: I have edits) |
| .video-js .vjs-live-control { | ||
| .vjs-live .vjs-time-control, | ||
| .vjs-live .vjs-time-divider, | ||
| .vjs-live .vjs-progress-control { |
There was a problem hiding this comment.
In keeping with the vjs-hidden stuff we were talking about, should we add the class to these in updateShowing?
There was a problem hiding this comment.
If you mean have the live component manage the visibility of the other components, I think that would become a mess. I did consider having each of those components hide itself when the player is live, but I'm on the fence and not sure where to draw the line of when we use CSS states and when we use javascript for hiding. I'm also not sure how Live+DVR will affect these, so for now I think I'd lean towards leaving them like this.
heff
force-pushed
the
fix-live
branch
3 times, most recently
from
6c5a1c6
to
025c77d
Compare
...and also the layout in IE8 when live Reorganized the styles some to group the vjs-live changes with the components their affecting. closes videojs#2551
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and also the layout in IE8 when live. Both are currently broken in the new skin.
Related to #2507