Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This adds 'ended' event documentation for API docs #2836

Closed
wants to merge 1 commit into from
Closed

This adds 'ended' event documentation for API docs #2836

wants to merge 1 commit into from

Conversation

tomaspinho
Copy link
Contributor

I have seen some people complaining that no documentation about the 'ended' event seems to exist in the official API docs. As I have needed to implement functionality with it, I decided to add it. Please consider.

@pam
Copy link

pam commented Nov 21, 2015

Tests passed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: 7accae7
Build details: https://travis-ci.org/pam/video.js/builds/92424373

(Please note that this is a fully automated comment.)

@gkatsev
Copy link
Member

gkatsev commented Nov 21, 2015

Thanks. LGTM

@gkatsev gkatsev added patch This PR can be added to a patch release. needs: LGTM Needs one or more additional approvals labels Nov 21, 2015
@dmlap
Copy link
Member

dmlap commented Nov 23, 2015

LGTM

@gkatsev gkatsev closed this in c4dbd24 Nov 23, 2015
@gkatsev gkatsev mentioned this pull request Nov 23, 2015
@gkatsev gkatsev removed the needs: LGTM Needs one or more additional approvals label Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch This PR can be added to a patch release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants