Correct adaptive layout selectors to match their intent #2923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were a few problems 1: The fullscreen button was hidden in vjs-layout-x-small, unlike its comments claimed and not matching with tiny, where it is visible. 2: The vjs-captions-control was hidden twice for tiny and x-small 3: The vjs-captions-control was hidden in small, even though the intent was (per comments) for it to be visible 4: The vjs-volume-menu-button was present on x-small, because it was incorrectly specified as .vjs-volume-button All of this was partly because the lines for each layout were different and thus 'hard' to compare between the layouts. I have now split them in 4 groups/lines. Time controls, rate/progress, volume, metadata. This will hopefully prevent similar problems in the future.
hartman
added a commit
to hartman/videojs-responsive-layout
that referenced
this pull request
Dec 17, 2015
This fixes: * an infinite loop (#6) * speeds up the settling of layout if multiple steps are required (#5) * only using default calculations when not using native controls * some of videojs/video.js#2923 in case users run older versions of video.js
|
ping.. anyone want to look at this ? |
|
❤️❤️ the reorganization. Much cleaner. I would remove fullscreen in tiny, that was almost certainly an oversight. Otherwise, looks good to me! 👍 |
|
@mmcc actually, the comments on line 3 (above the definition of tiny), indicate the fullscreen button in tiny was intentional. Could be changed of course. |
|
That it does. I could have sworn I meant for tiny to just be the play button, but two buttons is probably tiny enough :) |
|
lgtm |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a few problems
1: The fullscreen button was hidden in vjs-layout-x-small, unlike its
comments claimed and not matching with tiny, where it is visible.
2: The vjs-captions-control was hidden twice for tiny and x-small
3: The vjs-captions-control was hidden in small, even though the
intent was (per comments) for it to be visible
4: The vjs-volume-menu-button was present on x-small, because it was
incorrectly specified as .vjs-volume-button
All of this was partly because the lines for each layout were
different and thus 'hard' to compare between the layouts. I have now
split them in 4 groups/lines. Time controls, rate/progress, volume,
metadata. This will hopefully prevent similar problems in the future.