Buffer time-display component values to avoid refreshing HTML too often #3101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -55,7 +55,10 @@ class CurrentTimeDisplay extends Component { | |||
| let time = (this.player_.scrubbing()) ? this.player_.getCache().currentTime : this.player_.currentTime(); | |||
| let localizedText = this.localize('Current Time'); | |||
| let formattedTime = formatTime(time, this.player_.duration()); | |||
| this.contentEl_.innerHTML = `<span class="vjs-control-text">${localizedText}</span> ${formattedTime}`; | |||
| if(formattedTime !== this.formattedTime_){ | |||
There was a problem hiding this comment.
needs whitespace after if and before {, in remaining-time-display as well.
|
Thanks. This makes sense to me. Just needs a minor stylistic update. |
gkatsev
added
minor
|
LGTM |
gkatsev
added
confirmed
and removed
needs: LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTML reparsing is a costly action for the browser and these components need to be updated only once per second. To avoid getting updating too often the HTML, the HTML will only update if the input data change.