Fixes #2156 make controls visible #3237
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -10,6 +10,15 @@ | |||
| @include background-color-with-alpha($primary-background-color, $primary-background-transparency); | |||
| } | |||
|
|
|||
| // IE8 is flakey with fonts, and you have to change the actual content to force | |||
There was a problem hiding this comment.
oh, I see, it's for the variable. Maybe move just the variable but lease the section where it was?
gkatsev
added
needs: LGTM
|
LGTM. |
|
LGTM 👍 |
gkatsev
added
confirmed
minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the a11y issue in #2156, where keyboard and screen reader users lose control focus when the control bar hides due to inactivity. I set the controls to
visibility: visibleand tested with NVDA and JAWS across all supported browsers.For IE8, I opted to keep the controls hidden because
-ms-filter: "progid:DXImageTransform.Microsoft.Alpha(Opacity=0)";won't make all of the children transparent. More work could be done on the controls for IE8, if someone can make a compelling case for it.