Text tracks documentation updates #3256
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is one functional change where it logs a warning if it thinks that the lack of |
| <track src="http://example.com/oceans.vtt" kind="captions" srclang="en" label="English"> | ||
| </video> | ||
| ``` | ||
| One thing to be aware of is that in this case the video files themselves will *also* needs CORS headers applied to it. Since is because some browsers apply the crossorigin attribute to the video source itself and not just the tracks and is considered a [security concern by the spec](https://html.spec.whatwg.org/multipage/embedded-content.html#security-and-privacy-considerations). |
|
A few minor editorial suggestions, otherwise LGTM. |
|
Good changes, thanks. |
|
LGTM (in case my previous one didn't count!) |
|
Heh, thanks. I still have to add the other section about caption/subs+descriptions precedence with regards to defaults and menu selection and programmatic interfaces. |
|
@OwenEdwards the new section is in this commit: 33a7bca |
|
LGTM |
gkatsev
added
confirmed
documentation
minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the documentation for Text Tracks.
Fixes #1888, #1958, #2628, and #3202.