Chrome 50 does not set src attr on video element. #3287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I made some comments in #3071, I'm not necessarily opposed to making this change but we should understand it fully before merging if we can. |
gkatsev
added
needs: discussion
gkatsev
added
needs: updates
and removed
needs: confirmation
needs: discussion
|
@rbran100 hey, would you want to update this PR against master to get it pulled in? |
|
Ended up rebasing this myself and pulilng it in. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3071
Description
Chrome does not set the src attr and this causes autoplay to never trigger.
Specific Changes proposed
Check current src, it will hold the current source when multiple source video files are used.
Requirements Checklist