Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate errorDisplay as it can be disabled in options (fixes #3014) #3440

Closed
wants to merge 1 commit into from
Closed

Validate errorDisplay as it can be disabled in options (fixes #3014) #3440

wants to merge 1 commit into from

Conversation

ntadej
Copy link

@ntadej ntadej commented Jul 19, 2016

Description

All UI elements can be disabled in options for example

{
  'posterImage': false,
  'textTrackDisplay': false,
  'loadingSpinner': false,
  'bigPlayButton': false,
  'controlBar': false,
  'errorDisplay': false,
  'textTrackSettings': false
}

When errorDisplay is disabled it does not exist anymore. Thus its existence needs to be validated to avoid crashes. The one fixed occurs immediately after player is initialized.

Specific Changes proposed

Validate existence of this.errorDisplay. This fixes #3014.

Requirements Checklist

  • Bug fixed
  • Reviewed by Two Core Contributors

@gkatsev
Copy link
Member

gkatsev commented Jul 19, 2016

LGTM.

@gkatsev gkatsev added patch This PR can be added to a patch release. needs: LGTM Needs one or more additional approvals labels Jul 19, 2016
@brandonocasey
Copy link
Contributor

LGTM

@gkatsev gkatsev closed this in 4b4954e Jul 19, 2016
@gkatsev gkatsev removed the needs: LGTM Needs one or more additional approvals label Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch This PR can be added to a patch release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncaught TypeError: Cannot read property 'close' of undefined
3 participants