Separate fn.apply and stringify checks #3444
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IE10 correctly supports console.*.apply, but should also get the stringification treatment (because it uselessly logs "[object Object]" and similar). This avoids an issue where an "Invalid calling object" was triggered when trying to call console method(s) from a cached value.
|
Also: I tested (again) this change in all supported IE versions and it worked as expected. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes #3442 which was introduced by #3356.
IE10 correctly supports
console.*.apply, but should also get the "stringification" treatment (because it uselessly logs[object Object]and similar). This avoids an issue where an "Invalid calling object" was triggered when trying to call console method(s) from a cached reference (without a proper context object).Specific Changes proposed
console.*.applyis supported and whether or not arguments should be stringified.Requirements Checklist
Unit Tests updated or fixedN/ADocs/guides updatedN/AExample created (starter template on JSBin)