Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vjsstandard - Tests - Utils folder #3482

Merged
merged 2 commits into from
Aug 3, 2016
Merged

vjsstandard - Tests - Utils folder #3482

merged 2 commits into from
Aug 3, 2016

Conversation

brandonocasey
Copy link
Contributor

Description

lint all of the tests in the test/unit/utils folder

Requirements Checklist

  • Feature implemented / Bug fixed
  • Reviewed by Two Core Contributors

@misteroneill
Copy link
Member

LGTM

@misteroneill misteroneill added the needs: LGTM Needs one or more additional approvals label Aug 2, 2016
@misteroneill misteroneill added this to the Linting milestone Aug 2, 2016
ok(this === newContext);
QUnit.test('should add context to a function', function() {
const newContext = { test: 'obj'};
const asdf = function() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are great function names...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha

@gkatsev gkatsev added confirmed and removed needs: LGTM Needs one or more additional approvals labels Aug 2, 2016
@gkatsev
Copy link
Member

gkatsev commented Aug 2, 2016

LGTM

@misteroneill misteroneill merged this pull request into videojs:vjsstandard-core Aug 3, 2016
misteroneill pushed a commit to misteroneill/video.js that referenced this pull request Aug 3, 2016
@brandonocasey brandonocasey deleted the chore/test-linting-pt3 branch August 4, 2016 19:19
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants