Feature/clean up player objects in tests #3524
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From a quick once over in each of the files it looks like you got all the dispose calls that we were missing! |
|
also LGTM 😄 |
|
Nice. LGTM. Thanks @rlchung Ultimately, we'll want to refactor the tests such that this can be achieved in a |
|
LGTM. |
gkatsev
added
confirmed
minor
fixes #2895 for button.test.js fixes #2895 for controls.test.js fixed #2895 for setup.test.js fixed #2895 for video.test.js fixes #2895 for audio-tracks.test.js fixed #2895 for text-tracks.test.js fixed #2895 for video-tracks.test.js fixes #2895 cleans up player objects in tests fixes #2895 revision for trailing space error
|
@gkatsev Done! |
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed Issue #2895 ; cleaned up player objects in tests.
Added player.dispose() function where necessary.
Specific Changes proposed
N/A
Requirements Checklist