Fix MediaError #3562
Closed
Fix MediaError #3562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For future reference, you can now change the base of a PR without opening a new one: https://github.com/blog/2224-change-the-base-branch-of-a-pull-request |
|
Mind: blown! I've been wanting that feature for years. |
| if (typeof code === 'number') { | ||
| this.code = code; | ||
| } else if (typeof code === 'string') { | ||
| function MediaError(value) { |
There was a problem hiding this comment.
should this use the es6 class syntax, and be a constructor?
There was a problem hiding this comment.
I mean, it could, but I'd prefer not needing to go through another code review if it can be avoided.
|
LGTM other than my comment on es6 class syntax |
gkatsev
added
confirmed
and removed
needs: LGTM
gkatsev
pushed a commit
to gkatsev/video.js
that referenced
this pull request
Aug 24, 2016
| const createNativeMediaError = (code, message) => { | ||
| const err = Object.create(window.MediaError); | ||
|
|
||
| Object.defineProperty(err, 'code', {value: code}); |
|
Merged to stable, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discovered that attempting to construct a video.js
MediaErrorobject would fail to properly copy a nativeMediaErrorobject due to thecodeproperty being non-enumerable. Additionally, there were no tests for this module.This is a re-opening of #3560 against
stable.Specific Changes proposed
MediaErrorobjects from nativeMediaErrorobjects by manually assigning thecodeproperty.MediaErrorobject to be redundantly constructed, such that if it is called with a video.jsMediaErrorobject, it simply returns the same object. This removes the need for two code forks found elsewhere in the code.Requirements Checklist