Dispatch Flash events asynchronously #3700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkatsev
reviewed
Oct 21, 2016
| // invokes | ||
| // - Flash is suspended until the javascript returns which may cause | ||
| // playback performance issues | ||
| setTimeout(function() { |
There was a problem hiding this comment.
Maybe use tech.setTimeout()? It's theoretically possible that the tech would be disposed in between onEvent getting called at the timeout running.
misteroneill
requested changes
Oct 21, 2016
| // invokes | ||
| // - Flash is suspended until the javascript returns which may cause | ||
| // playback performance issues | ||
| setTimeout(function() { |
There was a problem hiding this comment.
Very minor, but should this use window.setTimeout instead?
There was a problem hiding this comment.
Nevermind. @gkatsev beat me to it. 😄
| tech.trigger(eventName, Array.prototype.slice.call(arguments, 2)); | ||
| const args = Array.prototype.slice.call(arguments, 2); | ||
|
|
||
| // dispatch Flash events after asynchronously for two reasons: |
There was a problem hiding this comment.
"after" should probably be removed
misteroneill
approved these changes
Oct 21, 2016
dmlap
force-pushed
the
async-flash-events
branch
from
984945e
to
ad6483f
Compare
Flash blocks until the javascript side of ExternalInterface callbacks complete and swallows any exceptions generated during that process. To avoid performance issues and missed exceptions, trigger events from Flash asynchronously.
dmlap
force-pushed
the
async-flash-events
branch
from
ad6483f
to
53ad29a
Compare
gkatsev
approved these changes
Oct 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Flash blocks until the javascript side of ExternalInterface callbacks complete and swallows any exceptions generated during that process. To avoid performance issues and missed exceptions, trigger events from Flash asynchronously.