Fix typos in functions guide #4035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mister-ben
commented
Feb 6, 2017
| @@ -63,7 +63,7 @@ var html5 = new Html5(options); | |||
| var Html5 = videojs.getTech('Html5'); | |||
| var MyTech = videojs.extend(Html5, {}); | |||
| // Register the new Tech | |||
| VjsButton.registerTech('Tech', MyTech); | |||
| videojs.registerTech('MyTech', MyTech); | |||
There was a problem hiding this comment.
videojs.registerTech() or Html5.registerTech() work here (but not MyTech.registerTech()). Which is prefered?
misteroneill
approved these changes
Feb 6, 2017
gkatsev
requested changes
Feb 6, 2017
docs/guides/videojs.md
Outdated
| @@ -43,9 +43,9 @@ var VjsButton = videojs.getComponent('Button'); | |||
| // Subclass the component (see 'extend' doc for more info) | |||
| var MySpecialButton = videojs.extend(VjsButton, {}); | |||
| // Register the new component | |||
| VjsButton.registerComponent('MySepcialButton', MySepcialButton); | |||
| VjsButton.registerComponent('MySpecialButton', MySpecialButton); | |||
There was a problem hiding this comment.
can we change this to be videojs.registerComponent as well?
brandonocasey
approved these changes
Feb 6, 2017
gkatsev
approved these changes
Feb 6, 2017
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.