Use dashes to format invalid times #627
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the number of seconds to be formatted is NaN or Infinity, use dashes to substitute for the digits.
Make sure it isn't mangled by Google closure.
| var s = Math.floor(seconds % 60), | ||
| m = Math.floor(seconds / 60 % 60), | ||
| h = Math.floor(seconds / 3600), | ||
| gm = Math.floor(guide / 60 % 60), | ||
| gh = Math.floor(guide / 3600); | ||
|
|
||
| // handle invalid times | ||
| if (window['isNaN'](seconds) || seconds === Infinity) { |
There was a problem hiding this comment.
Did you find the window and quotes in window['isNaN'] was actually needed? I would expect closure compiler to be aware of isNaN via the default externs and not mess with it.
There was a problem hiding this comment.
Yes, I had one failed build in Travis because I assumed the same. Maybe it wouldn't have if I had used isNaN without de-refing from window-- I didn't try that.
heff
added a commit
that referenced
this pull request
Aug 26, 2013
|
Right now it shows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the number of seconds to be formatted is NaN or Infinity, use dashes to substitute for the digits.