Allow event handlers registered with one() to be removed with off(). #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -329,8 +329,10 @@ vjs.trigger = function(elem, event) { | |||
| * @return {[type]} | |||
| */ | |||
| vjs.one = function(elem, type, fn) { | |||
| vjs.on(elem, type, function(){ | |||
| var func = function(){ | |||
| vjs.off(elem, type, arguments.callee); | |||
There was a problem hiding this comment.
while we're at it, can we get rid of arguments.callee since it has been deprecated?
We should be able to just put func in there instead.
There was a problem hiding this comment.
Ah, that'd be good. Would there be an issue with the var func being assigned after the function is created?
There was a problem hiding this comment.
It should be fine since the function gets called after func has been defined.
For example:
var foo = function() {
console.log(foo.toString());
};
foo();
// function() { console.log(foo.toString()); }
|
@delner Mind making that small change, and then I'll pull it in? |
|
Should be good to go; test worked fine on my fork. |
|
👍 |
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #658