Bug/callstack gh 860 #861
Closed
Bug/callstack gh 860 #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so that we can call Player#duration only if a duration exists. Otherwise, we get into an infinite loop and blow up the call stack.
| @@ -681,7 +686,7 @@ vjs.Player.prototype.duration = function(seconds){ | |||
| this.onDurationChange(); | |||
| } | |||
|
|
|||
| return this.cache_.duration; | |||
| return this.cache_.duration || 0; | |||
There was a problem hiding this comment.
I don't think zero would ever get used here. cache_.duration would either be undefined or a number. If it's undefined, onDurationChange on line 686 will set the value before this line is reached.
I think it will take some re-architecting to get it to default to zero properly.
There was a problem hiding this comment.
It actually does reach here in the special case of when the call stack blows up. In that case we never get a value set in the cache.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses bug #860.
First, we check to make sure that we got a duration from the
techGetcall, which may return nothing if the tech isn't ready yet, and then we call to update the duration if a duration exists. Otherwise, we don't.If we don't have a cached value for duration, we should default to returning zero.