Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove Firefox warnings about deprecated event props #8736

Merged
merged 2 commits into from
May 30, 2024
Merged

fix: Remove Firefox warnings about deprecated event props #8736

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f92eb23
fix: Remove Firefox warnings about deprecated event props
mister-ben May 17, 2024
6cfefb1
Merge branch 'main' into fix-ff-deprecated-props
mister-ben May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/js/utils/events.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,15 +112,19 @@ export function fixEvent(event) {
// IE8 Doesn't like when you mess with native event properties
// Firefox returns false for event.hasOwnProperty('type') and other props
// which makes copying more difficult.
// TODO: Probably best to create a whitelist of event props

// TODO: Probably best to create an allowlist of event props
const deprecatedProps = [
'layerX', 'layerY', 'keyLocation', 'path',
'webkitMovementX', 'webkitMovementY', 'mozPressure', 'mozInputSource'
];

for (const key in old) {
// Safari 6.0.3 warns you if you try to copy deprecated layerX/Y
// Chrome warns you if you try to copy deprecated keyboardEvent.keyLocation
// and webkitMovementX/Y
// Lighthouse complains if Event.path is copied
if (key !== 'layerX' && key !== 'layerY' && key !== 'keyLocation' &&
key !== 'webkitMovementX' && key !== 'webkitMovementY' &&
key !== 'path') {
if (!deprecatedProps.includes(key)) {
// Chrome 32+ warns if you try to copy deprecated returnValue, but
// we still want to if preventDefault isn't supported (IE8).
if (!(key === 'returnValue' && old.preventDefault)) {
Expand Down