Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change http to https in examples #8905

Merged
merged 3 commits into from
Nov 14, 2024
Merged

Conversation

bruce-usab
Copy link
Contributor

@bruce-usab bruce-usab commented Oct 31, 2024

Description

Two examples use http and not https.

Specific Changes proposed

href=http changed to href=https in two places in two files.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
    • Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab)
    • Has no changes to JSDoc which cause npm run docs:api to error
  • Reviewed by Two Core Contributors

Copy link

welcome bot commented Oct 31, 2024

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

Co-authored-by: mister-ben <1676039+mister-ben@users.noreply.github.com>
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.25%. Comparing base (ecef37c) to head (bda2a4c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8905   +/-   ##
=======================================
  Coverage   83.25%   83.25%           
=======================================
  Files         120      120           
  Lines        8097     8097           
  Branches     1944     1944           
=======================================
  Hits         6741     6741           
  Misses       1356     1356           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bruce-usab bruce-usab changed the title Change http to https in examples fix: change http to https in examples Nov 5, 2024
@bruce-usab
Copy link
Contributor Author

Renamed PR per Conventional Commits to address failed check:

GPR title check / Should follow conventional commit spec

@mister-ben mister-ben merged commit 079cbe1 into videojs:main Nov 14, 2024
11 of 12 checks passed
Copy link

welcome bot commented Nov 14, 2024

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants