-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Make seek bar keyboard skip increment configurable #8919
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8919 +/- ##
==========================================
+ Coverage 83.42% 83.83% +0.40%
==========================================
Files 120 120
Lines 8097 8096 -1
Branches 1944 1944
==========================================
+ Hits 6755 6787 +32
+ Misses 1342 1309 -33 ☔ View full report in Codecov by Sentry. |
Couple of points for feedback in particular:
|
* @param {number} [options.stepSeconds=5] | ||
* The number of seconds to increment on keyboard control | ||
* @param {number} [options.pageMultiplier=12] | ||
* The multiplier of stepSeconds that PgUp/PgDown move the timeline. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I always forget that page up/down works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😄
Description
Pressing the arrow and page keys seeks, currently by a set interval. This change makes this configurable.
Specific Changes proposed
Adds options that can be included in player options which set the increments to used.
Defaults remain as 5 seconds for left/right and 12x multiplier for page up/down.
Requirements Checklist
npm run docs:api
to error