Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac libvlc loading refactoring #163

Draft
wants to merge 10 commits into
base: 3.x
Choose a base branch
from
Draft

Conversation

mfkl
Copy link
Member

@mfkl mfkl commented Sep 10, 2020

Description of Change

Refactoring the libvlc loading for both Xamarin.Mac (cocoa) and netcore on mac targets to allow loading a libvlc dynamic build, as opposed to the current static custom built libvlc.dylib package.
This will allow to reuse the the official release builds, enabling us to do continuous delivery and will just work with libvlc 4 builds.
This PR still needs a bit of work and cleanup but it is mostly working. It relies on a new libvlc.mac nuget though, that needs to be pushed and will be incompatible with previous libvlcsharp versions.

Issues Resolved

API Changes

None

Platforms Affected

macOS on both Mono and .NET Core runtimes.

PR Checklist

  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant