Adding a MediaPlayerElement to Maui #352

jonx · 2024-06-18T18:01:03Z

Description of Change

This draft PR includes the implementation of a MediaPlayerElement for Maui. The changes include:

Added new MediaPlayerElement control to LibVCLSharp.MAUI
Added the sample LibVLCSharp.MAUI.Sample.MediaElement based on the Forms sample
Added the sample LibVLCSharp.MAUI.Sample.MediaElement.Multiple that aims at showing how to style and use two instances of the control on the same page - but it's not yet doing that. Both controls are the same style currently

Issues Resolved

fixes #637

Other Changes

The SvgTintColorBehavior.cs was meant to change the color or the SVG icons but it's not working and can be ignored

Platforms Affected

Core (all platforms)
Android

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

Not applicable

PR Checklist

Rebased on top of the target branch at time of PR
Changes adhere to coding standard

…ement port to .NET MAUI. Compiles and runs.

…ot successful.

App life cycle management rewrite. App state save.

…imize change.

Corrected the Strings.fr.resx build problem. Forward icon was not visible because the svg icon had the wrong name. Icons are white, until we find a better way to handle colors.

New Sample with multiple MediaElementPlayers in the same project.

jonx · 2024-06-18T18:10:13Z

The implementation is close to complete for Android but probably needs further testing.

I removed the dependance to AwesomeFont and replaced it with equivalent SVG files. The problem is that I can't change their color? I tried to implement a behavior to do that - it's in the project - but it's not working
I replaced Messaging center by WeakEventManager
The checks in the track list popup should be more constrained. The controls there need some refinement.
The lock slider has some initial drawing issues. The icon only appears once you scroll once for some reason.
This is only an Android port, but I suspect getting the iOS version should be quite easy given all we have here is cross-platform.
The video starts playing before the player is visible. Maybe it's related to how the player is embedded.

It's possible the issues I mention were there already in the Xamarin version.

Please review and provide feedback.

For some reason, you need to specify the complete path to the type on Windows.

mfkl · 2024-06-19T12:13:17Z

Looking good so far :-)

mfkl · 2024-06-21T13:48:53Z

I'm wondering whether it would be possible to keep the same code for XF and MAUI and just use #ifdef? Depends how much code is the same or different, besides namespaces.
Also I don't know when we will drop XF support, so going through the effort of supporting both from a single code base might not be worth it. Not sure.

Will attempt to run the iOS sample next week, keep you posted.

jonx · 2024-06-25T02:24:28Z

I guess it's possible in theory but I'm not sure how you're going to manage this. The way I see this is that it's probably less work to maintain both projects rather than having to add all the #ifdefs. Maybe there is an easy way to do such thing that I don't know of?

mfkl · 2024-06-25T19:40:18Z

After some setup and deployment struggles, I managed to run the sample on an iOS device.

Buttons are present and working, just invisible.

mfkl · 2024-07-03T21:38:54Z

Managed to display the play/pause icons in iOS with a hack. mfkl@66d3d52;

Still need to figure out how to include them transitively (from libvlcsharp.maui) as they were not present in the app bundle.

MAUI expects png references from XAML or C# as it translates the svgs.

The path from the generic theme appears to be from the app bundle, not the code project.

mfkl · 2024-07-05T19:56:58Z

src/LibVLCSharp.MAUI/LibVLCSharp.MAUI.csproj

+	<PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Debug|net7.0-android|AnyCPU'">
+	  <TreatWarningsAsErrors>False</TreatWarningsAsErrors>
+	</PropertyGroup>

+	<PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Debug|net6.0-ios|AnyCPU'">
+	  <TreatWarningsAsErrors>False</TreatWarningsAsErrors>
+	</PropertyGroup>

-	<ItemGroup>
+	<PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Release|net7.0-android|AnyCPU'">
+	  <TreatWarningsAsErrors>False</TreatWarningsAsErrors>
+	</PropertyGroup>
+
+	<PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Release|net6.0-ios|AnyCPU'">
+	  <TreatWarningsAsErrors>False</TreatWarningsAsErrors>
+	</PropertyGroup>


I think these can be removed.

mfkl · 2024-07-05T19:57:24Z

src/LibVLCSharp.MAUI/LibVLCSharp.MAUI.csproj

+  <ItemGroup>
+    <AndroidResource Remove="Handlers\**" />
+    <Compile Remove="Handlers\**" />
+    <EmbeddedResource Remove="Handlers\**" />
+    <MauiCss Remove="Handlers\**" />
+    <MauiXaml Remove="Handlers\**" />
+    <None Remove="Handlers\**" />
+  </ItemGroup>


these lines can be removed too I guess

mfkl · 2024-07-05T19:59:26Z

I'm thinking we can remove the Shared folder and namespace.

mfkl · 2024-07-05T20:01:52Z

For the image issue on iOS, Maui is supposed to translate them into pngs during build with proper size options but there are various bugs preventing it from doing it transitively. With a BundleResource I managed to have them in the app bundle but they're not translated into pngs and iOS cannot read SVG natively...

So we might be better off sticking to FontAwesome for now, as XF was doing.

jonx · 2024-07-15T19:23:35Z

Alright, thanks for the review. I'll update the PR based on your comments and will revert back the Fontawesome removal with the hope we won't face the same issue with icons.

TheSundayDev · 2024-07-26T12:19:30Z

hi,
can I ask if you have an estimation in order to be live? thans a lot!

jonx · 2024-07-26T17:00:25Z

Hello, I'll update the PR with the points discussed here by the end of next week. What platform are you interested in?

TheSundayDev · 2024-07-26T17:59:28Z

Hi,
MAUI ios and android for now.
thanks

jonx · 2024-07-26T20:00:33Z

Alright, in this case, if you're in a hurry, my PR code is working already and not much will change before the final version on Android. We're only having this bug on iOS that is not including the button icons from the library to the main project. I'm just going to revert to using fonts like the original xamarin was doing. Meaning you can potentially start integrating it in your project. If not, stay tuned for my update next week. Then it will probably take a little longer for the VLC# people to accept the PR.

mfkl · 2024-07-30T17:48:17Z

hi, can I ask if you have an estimation in order to be live? thans a lot!

Hi, we do not provide delivery estimate for opensource work, it is released when it's ready. If you'd like to speed up the process, you may check out the PR's branch locally and help improve it by fixing the remaining issues. Thanks.

TheSundayDev · 2024-08-14T11:54:52Z

hi, can I ask if you have an estimation in order to be live? thans a lot!

Hi, we do not provide delivery estimate for opensource work, it is released when it's ready. If you'd like to speed up the process, you may check out the PR's branch locally and help improve it by fixing the remaining issues. Thanks.

Hi,
I was just asking, I didn't want to push ;)

jonx · 2024-09-28T02:10:37Z

I'm closing this PR to sync my fork and create a new PR.
@TheSundayDev, you're welcome to test the new PR. Feedback welcome.

jonx added 7 commits June 4, 2024 21:39

WIP: Initial version. Merged and resolved conflicts for MediaPlayerEl…

5c5fe32

…ement port to .NET MAUI. Compiles and runs.

Tentative to create a behavior to change the color of the icons but n…

3f0bf53

…ot successful.

Minor changes.

4f511b6

App life cycle management rewrite. App state save.

App lifecycle management.

526ff10

App lifecycle refactoring to get back to the original version and min…

5f1c2f9

…imize change.

Corrected all warnings.

2370473

Corrected the Strings.fr.resx build problem. Forward icon was not visible because the svg icon had the wrong name. Icons are white, until we find a better way to handle colors.

Checked button size in overlay list.

63cb3e0

New Sample with multiple MediaElementPlayers in the same project.

Making LibVLCSharp.MAUI.Sample build.

a231469

For some reason, you need to specify the complete path to the type on Windows.

mfkl changed the title ~~Issue/637/media element for Maui 3.x - Adding a MediaPlayerElement to Maui~~ Adding a MediaPlayerElement to Maui Jun 25, 2024

mfkl reviewed Jul 5, 2024

View reviewed changes

jonx closed this Sep 28, 2024

jonx deleted the issue/637/MediaElement-for-MAUI-3.x branch September 30, 2024 12:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding a MediaPlayerElement to Maui #352

Adding a MediaPlayerElement to Maui #352

jonx commented Jun 18, 2024

jonx commented Jun 18, 2024 •

edited

Loading

mfkl commented Jun 19, 2024

mfkl commented Jun 21, 2024

jonx commented Jun 25, 2024

mfkl commented Jun 25, 2024

mfkl commented Jul 3, 2024

mfkl Jul 5, 2024

mfkl Jul 5, 2024

mfkl commented Jul 5, 2024

mfkl commented Jul 5, 2024 •

edited

Loading

jonx commented Jul 15, 2024 •

edited

Loading

TheSundayDev commented Jul 26, 2024

jonx commented Jul 26, 2024

TheSundayDev commented Jul 26, 2024

jonx commented Jul 26, 2024

mfkl commented Jul 30, 2024

TheSundayDev commented Aug 14, 2024

jonx commented Sep 28, 2024 •

edited

Loading

Adding a MediaPlayerElement to Maui #352

Adding a MediaPlayerElement to Maui #352

Conversation

jonx commented Jun 18, 2024

Description of Change

Issues Resolved

Other Changes

Platforms Affected

Behavioral/Visual Changes

Before/After Screenshots

Testing Procedure

PR Checklist

jonx commented Jun 18, 2024 • edited Loading

mfkl commented Jun 19, 2024

mfkl commented Jun 21, 2024

jonx commented Jun 25, 2024

mfkl commented Jun 25, 2024

mfkl commented Jul 3, 2024

mfkl Jul 5, 2024

Choose a reason for hiding this comment

mfkl Jul 5, 2024

Choose a reason for hiding this comment

mfkl commented Jul 5, 2024

mfkl commented Jul 5, 2024 • edited Loading

jonx commented Jul 15, 2024 • edited Loading

TheSundayDev commented Jul 26, 2024

jonx commented Jul 26, 2024

TheSundayDev commented Jul 26, 2024

jonx commented Jul 26, 2024

mfkl commented Jul 30, 2024

TheSundayDev commented Aug 14, 2024

jonx commented Sep 28, 2024 • edited Loading

jonx commented Jun 18, 2024 •

edited

Loading

mfkl commented Jul 5, 2024 •

edited

Loading

jonx commented Jul 15, 2024 •

edited

Loading

jonx commented Sep 28, 2024 •

edited

Loading