[MTGOSDK/Core/Remoting] RemoteHandle: Skip unresolved remote assembly…

… references

Fixes issue where dynamic assemblies such as SharedHarmonyState would prevent future clients from connecting when dumping remote types.

MTGOSDK/lib/ScubaDiver/src/Endpoints/Dumping/MakeTypesResponse.cs

@@ -25,7 +25,7 @@ private string MakeTypesResponse(HttpListenerRequest req)
     if (matchingAssembly == null)
       return QuickError($"No assemblies found matching the query '{assembly}'");
 
-    List<TypesDump.TypeIdentifiers> types = new List<TypesDump.TypeIdentifiers>();
+    List<TypesDump.TypeIdentifiers> types = new();
     foreach (Type type in matchingAssembly.GetTypes())
     {
       types.Add(new TypesDump.TypeIdentifiers() { TypeName = type.FullName });

MTGOSDK/src/Core/Remoting/RemoteHandle.cs

@@ -7,6 +7,7 @@
 using System.Diagnostics;
 using System.IO;
 
+using MTGOSDK.Core.Logging;
 using MTGOSDK.Core.Reflection;
 using MTGOSDK.Core.Remoting.Interop;
 using MTGOSDK.Core.Remoting.Interop.Interactions.Dumps;
@@ -127,7 +128,15 @@ internal RemoteHandle(Process procWithDiver, DiverCommunicator communicator)
     _currentDomain = communicator.DumpDomain();
     foreach (string assembly in _currentDomain.Modules)
     {
-      _remoteTypes.Add(assembly, communicator.DumpTypes(assembly));
+      try
+      {
+        _remoteTypes.Add(assembly, communicator.DumpTypes(assembly));
+      }
+      catch (Exception e)
+      {
+        Log.Error("Failed to dump types for assembly '{Assembly}': {Message}",
+          assembly, e.Message);
+      }
     }
     _remoteObjects = new RemoteObjectsCollection(this);
     Activator = new RemoteActivator(communicator, this);
@@ -191,6 +200,9 @@ public IEnumerable<CandidateType> QueryTypes(string typeFullName)
   {
     foreach (string assembly in _currentDomain.Modules)
     {
+      if (!_remoteTypes.ContainsKey(assembly))
+        continue;
+
       foreach (TypesDump.TypeIdentifiers type in _remoteTypes[assembly].Types)
       {
         if (type.TypeName == typeFullName)