Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trackbar on DVR mode should allow seeking only through segments available on current playlist #1417

Closed
renatofrota opened this issue Aug 31, 2024 · 2 comments
Labels
feature New feature or request

Comments

@renatofrota
Copy link

When using stream-type="live:dvr" the trackbar allows seeking back and the trackbar "window" keeps growing despite the older segments being removed from the m3u8 playlist.

e.g.: after 10 minutes in a live stream, with 3 minutes of playback segments available, the left edge of the trackbar represents the timestamp "-10:00" (instead -3:00).

The position -10:00 is clicable but player automatically seeks to "-3:00", which is the closest available segment to the timestamp selected - pretty good!! (other players seeks to the live edge or just freeze).

However, it would be an even better user experience if the tracking bar was updated to represent the available playlist segments (only the window from -3:00 to live).

[off] WHAT A GREAT PLAYER!! 👏🏽👏🏽👏🏽
Thanks @mrlika for the recommendation 😀

@renatofrota renatofrota added the feature New feature or request label Aug 31, 2024
@renatofrota
Copy link
Author

renatofrota commented Aug 31, 2024

after further testing, it seems clicking -10:00 (with only 3 minutes of playback available) player just seeks to live (considering a margin to the live edge - respecting liveSyncDuration) - not to the oldest available segment (-3:00) as I've said previously.

I've noticed another problem: after seeking back, it's possible to seek forward, closer to the live edge than configured at liveSyncDuration (even setting live-edge-tolerance). This is a serious problem for P2P implementations.

e.g.:

live-edge-tolerance="60"
liveSyncDuration: 60

  • when stream starts, we are 60s behind the live edge;
  • after seeking to -1:00, the tracking bar is updated and "discloses" the existence of the 60s of playback available ahead;

ideally:

  • seeking to any point of the trackbar, if that position is not available, it should seek to the closest available segment instead to "live" (live - sync margin);
  • the trackbar should not disclose there are more segments available ahead of the liveSyncDuration / liveSyncDurationCount or live-edge-tolerance;
  • the trackbar should represent only the segments currently available in the playlist (or as closest as possible to that);

mihar-22 added a commit that referenced this issue Sep 14, 2024
@mihar-22
Copy link
Member

Thanks a lot for the testing and feedback! I've pushed up a bunch of small fixes which should improve the live playback experience. It's really hard for me to figure it out right now as I don't have live test streams (DVR/not). If you can try out the next release (should be out today or at most next few days) that'd be awesome. Happy to keep tweaking until we get it right. I'll reopen when needed :)

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants