Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fgetcsv default values are deprecated with 8.4 #531

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

remicollet
Copy link
Contributor

Using 8.4.0RC1

========DIFF========
     bool(true)
002+ 
003+ Deprecated: fgetcsv(): the $escape parameter must be provided as its default value will change in /dev/shm/BUILD/php84-php-pecl-xlswriter-1.5.7/xlswriter-1.5.7/tests/xlsx_to_csv_callback.php on line 25
     array(2) {
       [0]=>
       string(4) "Item"
       [1]=>
       string(4) "Cost"
     }
010+ 
011+ Deprecated: fgetcsv(): the $escape parameter must be provided as its default value will change in /dev/shm/BUILD/php84-php-pecl-xlswriter-1.5.7/xlswriter-1.5.7/tests/xlsx_to_csv_callback.php on line 26
     array(4) {
       [0]=>
       string(6) "Item_1"
--
========DONE========
FAIL Check for vtiful presence [tests/xlsx_to_csv_callback.phpt] 
                                                    
========DIFF========
     bool(true)
002+ 
003+ Deprecated: fgetcsv(): the $escape parameter must be provided as its default value will change in /dev/shm/BUILD/php84-php-pecl-xlswriter-1.5.7/xlswriter-1.5.7/tests/xlsx_to_csv_callback_custom_delimiter.php on line 25
     array(2) {
       [0]=>
       string(4) "Item"
       [1]=>
       string(4) "Cost"
     }
010+ 
011+ Deprecated: fgetcsv(): the $escape parameter must be provided as its default value will change in /dev/shm/BUILD/php84-php-pecl-xlswriter-1.5.7/xlswriter-1.5.7/tests/xlsx_to_csv_callback_custom_delimiter.php on line 25
     array(4) {
       [0]=>
       string(6) "Item_1"
--
       [3]=>
       string(10) "10.9999995"
     }
022+ 
023+ Deprecated: fgetcsv(): the $escape parameter must be provided as its default value will change in /dev/shm/BUILD/php84-php-pecl-xlswriter-1.5.7/xlswriter-1.5.7/tests/xlsx_to_csv_callback_custom_delimiter.php on line 25
========DONE========
FAIL Check for vtiful presence [tests/xlsx_to_csv_callback_custom_delimiter.phpt] 
                                                   
========DIFF========
     bool(true)
002+ 
003+ Deprecated: fgetcsv(): the $escape parameter must be provided as its default value will change in /dev/shm/BUILD/php84-php-pecl-xlswriter-1.5.7/xlswriter-1.5.7/tests/xlsx_to_csv_custom_delimiter.php on line 23
     array(2) {
       [0]=>
       string(4) "Item"
       [1]=>
       string(4) "Cost"
     }
010+ 
011+ Deprecated: fgetcsv(): the $escape parameter must be provided as its default value will change in /dev/shm/BUILD/php84-php-pecl-xlswriter-1.5.7/xlswriter-1.5.7/tests/xlsx_to_csv_custom_delimiter.php on line 23
     array(4) {
       [0]=>
       string(6) "Item_1"
--
       [3]=>
       string(10) "10.9999995"
     }
022+ 
023+ Deprecated: fgetcsv(): the $escape parameter must be provided as its default value will change in /dev/shm/BUILD/php84-php-pecl-xlswriter-1.5.7/xlswriter-1.5.7/tests/xlsx_to_csv_custom_delimiter.php on line 23
========DONE========
FAIL Check for vtiful presence [tests/xlsx_to_csv_custom_delimiter.phpt] 

@viest viest merged commit d1571c5 into viest:master Oct 7, 2024
8 checks passed
@remicollet remicollet deleted the issue-php84 branch October 7, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants