Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-local browse is broken #74

Closed
sjoubert opened this issue Oct 30, 2019 · 3 comments
Closed

Non-local browse is broken #74

sjoubert opened this issue Oct 30, 2019 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@sjoubert
Copy link
Contributor

With #65 two use cases seem broken now:

  1. The generated report can't be served by an HTML server anymore since the repostat installation dir is likely not in correct folders allowed by the server. For example, aggregating the report as Jenkins artifacts now only serves the html. Jenkins refuses to provided the css and js from the repostat installation dir.
  2. The generated report is not relocatable anymore. For example, generating reports on a build machine then aggregating multiple reports on a single host dedicated to stats requires repostat to be installed on the end machine (and in the same place as the build hosts)

I don't know what were the reason for removing the assets from the report (reducing space usage I guess, but the assets size is not that big), but having standalone relocatable reports should be a valid use case in my opinion.

@vifactor
Copy link
Owner

I did not think about the usecase you mentioned. The idea was to clean the report folder and to remove not so nice code.

I may try to add a cmd option --copy-assets

@vifactor vifactor added the bug Something isn't working label Oct 30, 2019
@sjoubert
Copy link
Contributor Author

IMO having a standalone report folder should be the default as I think people may be confused in these broken cases. I'd prefer a --no-copy--assets if needed but --copy--assets would work too.

@vifactor vifactor self-assigned this Oct 31, 2019
@vifactor vifactor added enhancement New feature or request and removed bug Something isn't working labels Oct 31, 2019
@vifactor
Copy link
Owner

@sjoubert , I have provided the option to make report relocatable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants