[#10] Rename ddev project #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuapease
reviewed
May 20, 2024
There was a problem hiding this comment.
Hah!
Yeah this is fine to change. Maybe we call it viget-craft-starter to make the likelihood of a collision even lower?
The only other spot to change is the create project script that renames the DDEV config when it makes your new site.
https://github.com/vigetlabs/craft-site-starter/blob/5.x/install-scripts/rename-ddev.php#L17
JJimmyFlynn
approved these changes
May 22, 2024
maxdmyers
approved these changes
May 23, 2024
|
Replace the commit with one that has And noting that Nevin pointed out in slack that if the name conflicts for folks working on both this and https://github.com/AdCouncil/craft-starter/ a local |
joshuapease
approved these changes
May 24, 2024
JJimmyFlynn
approved these changes
May 25, 2024
ten1seven
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames the
ddevproject name in the config.This prevents DDEV from complaining that "this project is already listed" if https://github.com/AdCouncil/craft-starter/ is already locally installed and set up.
Is this an OK change?