This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
ci: pass tests on Windows #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already have Bazel Caching so I doubt we even needed this.
Closed
sr229
added
the
hacktoberfest
sr229
approved these changes
Oct 11, 2021
Speykious
pushed a commit
that referenced
this pull request
Oct 11, 2021
* build: copy opencv.BUILD from MediaPipeUnityPlugin * chore: current end_of_line is LF * build: remove opencv_deps option * ci: enable Windows * build: pass environment variables to build OpenCV * ci: disable LAPACK * ci: ignore SignalAbortTest on Windows * test: fix tests on Windows * doc: remove an incorrect line * Do not upload contents of build/ We already have Bazel Caching so I doubt we even needed this. Co-authored-by: Capuccino <ayane@vignetteapp.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #23
This PR enables us to build
libmediapipe_c.sowith--opencv cmakeoption on Windows.Disabled tests on Windows CI are restored, too.
In order to pass all tests, I also fixed:
DllNotFoundExceptionthat occurs when any native APIs are called.[DllImport('mediapipe_c')], it seems that Windows loader cannot findlibmediapipe_c.dll.Packet#DebugTypeNamereturns different results than when run on Linux.By the way, I heard that EmguCV (OpenCV 4.x) is used in this project.
If so, I think it's not ideal to link OpenCV (3.4.10) statically, and
libmediapipe_c.dllshould link to the OpenCV library that EmguCV uses.Major Changes
end_of_linein.editorconfigto match the current newline of most files.ci.ymluses CR+LF, and diffs got larger.libmediapipe_c.soon Windows (i.e.--opencv cmake).Notes
C:\_bzl) isn't still cached.WITH_LAPACKoption is disabled, because it can take +20 minutes more than without it on CI.