-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated to the most recent version of foundry-vtt-types. Added support for setting, getting, configuration and saving of time related settings. Some test functions playing around with journal entries. Added displaying the clock below the calendar. Added controls for changing the hour,minute,second. These will probably change in look and feel but not functionality.
Added support for the bug reporter module to directly report found bugs. Added a built in time keeper that can increment the game time as real life time passes. This time keeper does not increment time if the game is paused OR combat has started. Sockets are used to ensure all players are being updated of the time correctly. Added a hook for the gameWorldTime updates and appropriate functions for setting the Simple Calendars time based on the new game world time. This supports integrations with other modules. Added hooks for when combat is updates or deleted to ensure that we pause/start the built in time keeper appropriately. Added a hook for when the game is paused/unpaused to pause/start the built in time keeper appropriately. Changed the interface for the GM controls to support changing the different time units. Added a new control for starting/stopping the built in time keeper. Added an indicator (animated clock) if the built in time control is running, paused or stopped. Added configuration options for setting how Simple Calendar integrates with the game world time: None - No integration, Self - Controls the game world time; ignores updates from other modules, Third Party - only follows game world time updates from other modules and won't update the game world time itself and Mixed - Updates the game world time and follows updates from other modules. Added a configuration option to show/hide the clock. This will also show/hide the time controls (for games that dont care about hourly time). Added the ability to import other modules data into simple calendar or export simple calendars data ino other modules. Fixed a bug where more than 1 calendar configuration window could be opened (causing potential saving issues)
Updated all tests to work with the new code.
…f Simple Calendar grows it was getting to be too large of a single document. Updated the documentation for the new Time features. Restyled the configuration tabs to look a little better. Added links to the documentation directly to the configuration window.
… This requires a GM to be logged in as our custom socket sends a request to save the note from the player. Added a setting that lets GMs choose if players can add notes or not. Updated the documentation around players being able to add notes. Updated all unit tests.
Seasons can be added under the year settings. Each season is given a name, starting date and color. The Calendar display now shows the season's name below month/year title. The Calendar displays background color is also set based on the current season. Updated all of the predefined calendars to have their seasons set.
Fixed a typo in the season configuration interface.
Created the configuration interface for adding/removing/editing moon configurations. Revamped the back end of the configuration class to clean up a bunch of code and simplify things a bit. Updated some styling for the configuration page. Fixed an issue where the drop down day selector wouldn't update when a months days had changed. Added some missing localization strings in the configuration form. Fixed an issue where removing all settings wouldn't properly update the calendar.
…he season based on what is being viewed not just the current date. Added a title to the notes indication that will show the the text "X Notes" Where x is the number. this should hopefully help with accessibility. Fixed an issue where intercalary days were not being properly counted when determining how many days it has been so far. This resolves the inconsistencies we were seeing with about-time. Updated the configuration for moons for better layout and some addition options. Updated the formula for determining the phase of a moon on any given day. Added the displaying of the single moon phases on the calendar and the current/selected days current moon phase
Updated documentation and images for the newer version. Updated the unit tests to work with the changes for the moons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.