Using generic instead of object and rename #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
vikasvb90
approved these changes
Aug 31, 2023
| @@ -14,7 +14,7 @@ | |||
| * the Apache License, Version 2.0 (the "License"); you may | |||
| * not use this file except in compliance with the License. | |||
| * You may obtain a copy of the License at | |||
| * | |||
| *Ø | |||
There was a problem hiding this comment.
Nit: Remove unintended change.
| throw new IllegalArgumentException("Unknown crypto metadata object received"); | ||
| } | ||
| return (EncryptionMetadata) cryptoContext; | ||
| private EncryptionMetadata validateEncryptionMetadata(EncryptionMetadata cryptoContext) { |
There was a problem hiding this comment.
We can remove this method now.
| @@ -45,6 +45,7 @@ | |||
| import java.util.Map; | |||
|
|
|||
| @SuppressWarnings({ "rawtypes" }) | |||
| // Move this to EncryptionHandler | |||
There was a problem hiding this comment.
I don't think we should. If we move it there then we won't have a single encapsulation for encryption metadata. We will have to define new metadata schema and creation of this metadata will add redundant code to create metadata.
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.