Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refactor of integrations #159

Merged
merged 6 commits into from
Dec 23, 2024
Merged

Minor refactor of integrations #159

merged 6 commits into from
Dec 23, 2024

Conversation

phonzammi
Copy link
Member

@phonzammi phonzammi commented Dec 22, 2024

In this PR, we make minor changes to refactor the integrations of vike-react-antd and vike-react-styled-components.

Update:
We also refactor vike-react-styled-jsx a bit to simplify conditional logic

@phonzammi phonzammi marked this pull request as ready for review December 23, 2024 13:57
@phonzammi
Copy link
Member Author

Hi Rom, the PR is ready for review, Please.

@brillout
Copy link
Member

LGTM. Loving the extra polishing. Intervention -= 5.

Please merge. Don't squash (so that release-me makes fine gain commit assignements to the right packages).

@phonzammi phonzammi merged commit 225beda into main Dec 23, 2024
7 checks passed
@phonzammi phonzammi deleted the phonzammi/dev branch December 23, 2024 14:22
@phonzammi
Copy link
Member Author

Merged 🚀 . Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants