Skip to content

Commit

Permalink
fix CI's git env vars
Browse files Browse the repository at this point in the history
  • Loading branch information
brillout committed Jul 24, 2022
1 parent b8060ac commit 9e3ad05
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,5 @@ jobs:
- name: Run tests
run: ${{ matrix.testCmd }}
env:
GIT_REPOSITORY: ${{ github.repository }}
GIT_BRANCH: ${{ github.ref_name }}
CF_ACCOUNT_ID: ${{ secrets.CF_ACCOUNT_ID }}
CF_API_TOKEN: ${{ secrets.CF_API_TOKEN }}
2 changes: 1 addition & 1 deletion examples/cloudflare-workers-react-full/.testRun.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ function testRun(cmd: 'npm run dev' | 'npm run preview', { hasStarWarsPage }: {
const isWrangler = cmd === 'npm run preview'

if (isGithubAction()) {
const repository = process.env['GIT_REPOSITORY']
const repository = process.env['GITHUB_REPOSITORY']
expect(repository).toBeTruthy()
// GitHub Actions doesn't make secrets available to Pull Requests.
// - https://git.luolix.topmunity/t/feature-request-allow-secrets-in-approved-external-pull-requests/18071/4
Expand Down

0 comments on commit 9e3ad05

Please sign in to comment.