Skip to content

Commit

Permalink
delete badcat theme
Browse files Browse the repository at this point in the history
  • Loading branch information
@get-me-power
get-me-power committed Jan 12, 2020
1 parent 9cfa14a commit 4098d3a
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 83 deletions.
82 changes: 0 additions & 82 deletions autoload/airline/themes/badcat.vim
View file

This file was deleted.

1 change: 0 additions & 1 deletion doc/airline-themes.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ Currently this repository contains the following themes:
* ayu_light
* ayu_mirage
* ayu_dark
* badcat
* badwolf
* base16 (|airline-theme-base16|)
* base16_vim (|airline-theme-base16_vim|)
Expand Down

13 comments on commit 4098d3a

@magusr
Copy link

@magusr magusr commented on 4098d3a Apr 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove badcat

@jep-dev
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seriously. With a reference to badcat in your config, this is a backward incompatible change, and restoring it from the raw here appears to work. You were selective and thorough (removing all the references to badcat in docs, etc.) so I trust you had a reason, and you deleted it over fixing/hiding/deprecating it somehow. Just how bad is this cat??

bad-cat.jpg

@get-me-power
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@magusr @jep-dev

The badcat airline theme is supported by the following repositories and has been removed from vim-airline-themes to prevent batting.
Please see this repo.

https://github.com/emanuelrosa/badcat

@cupcake99
Copy link

@cupcake99 cupcake99 commented on 4098d3a May 24, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is stupid. That repo recommends that you use the vim-airline-themes repo with 'badcat' included.

Edit: Forked and reinstated badcat theme if anybody wants it: https://github.com/cupcake99/vim-airline-themes.git

BTW what is 'batting'?

@get-me-power
Copy link
Member Author

@get-me-power get-me-power commented on 4098d3a May 25, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW what is 'batting'?

Please see this Link

#121
#191

badcat colorscheme already includes the airline color scheme.
Why do vim-airline-themes need a badcat theme?
In fact, the badcat repository contains the exact same themes removed from vim-airline-themes.

@chrisbra
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look it is simple: the airline themes accompany the corresponding colorschemes. That means, you have to clone the badcat colorscheme repository already which comes with its own airline-theme already. So why would you want to have to install the same theme twice? That is just redundant and will lead to diverge themes sooner or later.
Having the same theme here and upstream, will just mean, those themes will diverge and no-one knows who is upstream and what the relevant theme should actually look like. Therefore it was decided to remove it from this repository.

@cupcake99
Copy link

@cupcake99 cupcake99 commented on 4098d3a May 25, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look it is simple: the airline themes accompany the corresponding colorschemes. That means, you have to clone the badcat colorscheme repository already which comes with its own airline-theme already

Yeah? Well when i did that it wouldn't load. So why should i waste more of my life trying to fix something that worked before you broke it? You computer people think you're so clever following 'best practice', but use it as a cover for unthinking automatic behaviour. The badcat repo isn't exactly the world's most mutable project, having had no changes in over 4 years. You'd think it would be safe to keep. Oh, but that would require actual thinking...

Also, did you ever think that perhaps people use a theme on airline that differs from the main vim theme? Hmm? Hmm?

I'll happily stick to my fork now anyway, thanks for following that 'best practice'.

@chrisbra
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, now we are getting angry? If the existing theme did not work for you, perhaps it would be more beneficial to try to figure out why it did not work for you? But rather you like to rant here. Oh well. BTW: If you have any suggestions no how to improve the existing "best practices" we are all ears.

@cupcake99
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, by 'exisiting theme', what are you referring to? Let me explain: i had a working vim-airline setup, using the formerly bundled badcat airline theme, which broke yesterday when i ran the vim-plug auto-update for my plugins. So, once i figured out what was going on, i installed the badcat repo as suggested above (using vim-plug), but my airline theme did not change from the default 'dark', and i kept getting 'Could not resolve airline theme "badcat"' messages, because i do not use badcat as my main vim theme. So, i would either need to set my whole vim theme to badcat, which i do not want to do, or revert to a previous commit and miss out on any bug fixes and feature updates.

You could change your practices to use common sense when making considerations about diverging themes, like for instance, taking into account the fact that the theme you just removed because you were worried about doubling or clashes, is in fact unmaintained, or not actively being updated, and states on their README that they suggest using vim-airline-themes. That to me seems like a divergence which is in fact a breaking change on your side, because now the people who want to follow the guidance of the badcat devs on their repo will not be getting the same behaviour as they had before.

And like i said, some people don't want to use the same theme for airline as for their main theme. So it's broken. For no reason but worries over something that hasn't happened and isn't likely to happen, and is only a consideration of 'best practice' repo maintenance in a case where it isn't necessary, nor a huge issue should something change upstream, which as i can see, is extremely unlikely.

@cupcake99
Copy link

@cupcake99 cupcake99 commented on 4098d3a May 25, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To put it in short: you've made the assumption that people who use a specific airline theme are also using that as their main vim theme, when that is not always the case, and so have made a choice which is a breaking change for some of the users of your plugin.

@cupcake99
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just checked that i am correct, and yes, if i change my main vim colourscheme to badcat the airline theme updates properly, but when i have it set to something else i get the error message. So your suggestions for usage are wrong, or acting on a wrong assumption, which breaks previous behaviour.

@chrisbra
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so you have installed the badcat colorscheme, which comes with an airline extension. So :AirlineTheme badcat should work, no? If the colorscheme exists locally, the extension is also available.

To put it in short: you've made the assumption that people who use a specific airline theme

So what are your exact recommendations to prevent that 2 different Airline Themes exists, which might diverge sometime in the future? I have not yet seen a convincing argument to have duplicate works stored in redundant places. If you want to have this fixed, how about contributing and trying to resolve this situation with both upstream repositories? (hint!)

@cupcake99
Copy link

@cupcake99 cupcake99 commented on 4098d3a May 25, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, i see what is happening now, i was trying to load a theme but did not have airline-themes running, so because of that it was throwing an error. If i have airline-themes as well as the badcat repo installed with vim-plug it works, but i now need two plugins where i only needed one before, as i have no need of the main badcat theme.

I don't know what i could contribute, and don't spend much time thinking about checking repositories for updates and also have no idea how to make hooks in git or whatever. I doubt the badcat repo will ever change, so what would i need to do? I am not a programmer.

Edit: also if i have my fork of airline-themes as well as the badcat scheme installed via vimplug i seem to get an error from airline. Is that the original problem you were trying to avoid? If so, why doesn't airline have enough intelligence to favour the colourscheme plugin over its bundled theme rather than just not know what to do.?

Please sign in to comment.