Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base16 templates #64

Closed
dawikur opened this issue Dec 26, 2016 · 7 comments
Closed

base16 templates #64

dawikur opened this issue Dec 26, 2016 · 7 comments

Comments

@dawikur
Copy link

dawikur commented Dec 26, 2016

I am currently working on base16-gruvbox schemes.
What I see here; quite a lot of similar code; looks like great candidate for base16 template.

Generating gui and cterm colors is straightforward (https://github.com/chriskempson/base16-vim/blob/master/templates/default.mustache).

Issue is with differences between schemes - each one can define its own versions of colors for modes. So for me it would be best to have base16-gruvbox-airline-template instead of base16-aitline-template (like one degree of freedom more).

Have you thought about it?

@chrisbra
Copy link
Member

I don't understand what you would like to have changed?

@dawikur
Copy link
Author

dawikur commented Dec 28, 2016

Not change, but I am wondering if adding template for base16 colors for airline would be useful and even possible.

@mshkrebtan
Copy link
Contributor

@dawikur Are you talking about vim-airline color schemes? Take a look at #63. Isn't that what you want? It works good for me for all the Base16 Shell themes I tried.

@dawikur
Copy link
Author

dawikur commented Dec 29, 2016

@mshkrebtan Not really, please see my comment under the PR 😄

@chrisbra
Copy link
Member

So you want to include a template theme. I am still not sure, how this is supposed to work. Do you want the template being sourced by other themes? I think that should work if you use source command, but not sure. I am definitly in favor of such a change.

@iamsubhranil
Copy link

iamsubhranil commented Jul 7, 2017

@chrisbra the template should provide a basic building block for writing a new theme. Newbies(like me) will just have to put appropriate colors in appropriate values. Base16 themes are really identical except for the colors, and I think all other themes in this repo should follow the same template. Its a neat one really.

@chrisbra
Copy link
Member

that is probably, because most of the base16 themes were somehow auto-generated. BTW: the default dark theme can be used as a template, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants