Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base16_shell theme #63

Merged
merged 1 commit into from
Jan 17, 2017
Merged

Conversation

mshkrebtan
Copy link
Contributor

@mshkrebtan mshkrebtan commented Dec 17, 2016

base16_shell theme for vim-airline matches an active Base16 Shell
theme.

It should be used in combination with Base16 Shell, which sets the
correct colors in the terminal:
(https://github.com/chriskempson/base16-shell).

The colors used in this theme are within the 21 term colors set by
Base16 Shell. The theme supports 2 options described in the docs.

@chrisbra
Copy link
Member

please squash and add documentation.

base16_shell theme for vim-airline matches an active Base16 Shell
theme.

It should be used in combination with Base16 Shell, which sets the
correct colors in the terminal:
(https://github.com/chriskempson/base16-shell).

The colors used in this theme are within the 21 term colors set by
Base16 Shell.  The theme supports 2 options described in the docs.
@mshkrebtan
Copy link
Contributor Author

@chrisbra Please review! :)

@mshkrebtan mshkrebtan changed the title Correct theme for base16-shell Add base16_shell theme Dec 29, 2016
@mshkrebtan mshkrebtan mentioned this pull request Dec 29, 2016
@dawikur
Copy link

dawikur commented Dec 29, 2016

Don't you think those let s:gui_* = #RRGGBB values will differ for each scheme? For cterm this is fine as this uses terminal color palette, but for gui version it uses its own colors instead of scheme.

Also how you define palettes (s:N1, s:N2, s:I3, etc) does not allow scheme to specify its own colors.

I don't think this commit is the ultimate solution for base16 schemes.

@mshkrebtan
Copy link
Contributor Author

@dawikur I left the GUI-related part untouched. And you are right, the gui values are hardcoded and match only one exact theme. This vim-airline theme can only match command-line vim.

Is it actually possible to integrate Base16 Shell with GUI vim?

@dawikur
Copy link

dawikur commented Dec 29, 2016

Well, base16-vim/shell defines colors also in #RRGGBB, unfortunately both of them unsets those variables at the end. That is why I was asking about template for base16 colors for airline (see #64 )

@chrisbra chrisbra merged commit bf5ea0d into vim-airline:master Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants