Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update colours for both Ubaryd and Laederon themes #161

Merged
merged 1 commit into from
Nov 12, 2018

Conversation

Donearm
Copy link
Contributor

@Donearm Donearm commented Nov 9, 2018

version updating for both themes

@chrisbra
Copy link
Member

chrisbra commented Nov 9, 2018

why are those colors changed?

@Donearm
Copy link
Contributor Author

Donearm commented Nov 9, 2018

I've tweaked the airline theme to match better the original ViM theme and to fix high contrast occasions that previously made the airline themes not so nice to stare at

@chrisbra
Copy link
Member

hm, Should that be made configurable?

@Donearm
Copy link
Contributor Author

Donearm commented Nov 11, 2018

by changing the palette global variable it is configurable but I don't see the need of letting users change colours. If you don't like a them just choose another one, no?

@chrisbra
Copy link
Member

chrisbra commented Nov 11, 2018 via email

@chrisbra
Copy link
Member

chrisbra commented Nov 11, 2018 via email

@Donearm
Copy link
Contributor Author

Donearm commented Nov 11, 2018

Usually, that's what forks and issues are for 😉

anyway, do you have an example of how to make the switch easy from the new to the old, and viceversa, with a global variable, perhaps? I admit I wouldn't know where to start to implement it

@chrisbra
Copy link
Member

let me merge it and await complaints ;)

@chrisbra chrisbra merged commit 0119604 into vim-airline:master Nov 12, 2018
@chrisbra
Copy link
Member

here we go: #162

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants