Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[add] github actions #241

Merged
merged 1 commit into from
Dec 17, 2020
Merged

[add] github actions #241

merged 1 commit into from
Dec 17, 2020

Conversation

get-me-power
Copy link
Member

According to an email from travis-ci, travis-ci.org will be officially closed down completely on December 31st, 2020
Therefore, We should consider migrating vim-airline's CI.

I wrote a PR to add github-actions because I thought it was less restrictive and faster to build with github-actions than travis-ci.com.

@get-me-power
Copy link
Member Author

Strangely enough, only vim8.2.0000 does not terminate the test successfully...

@get-me-power
Copy link
Member Author

get-me-power commented Dec 14, 2020

@chrisbra

note: I'm using action-setup-vim, which simplifies setting up the Vim environment in Github Actions, and there are two types of it. In vim-airline, use thinca/action-setup-vim.

I think the difference is that the former uses cache and the latter does not.
I used the former, but faced the problem that vader.vim did not work well with vim8.2.0000.
As a test, I used the latter, action-setup-vim, which does not have a cache, and the test was confirmed to finish successfully.
My guess is that the cached vim is incompatible with vader.vim (not exact information).
However, since the latter has been tested successfully with the same process that was done in travis, why not apply the latter this time?

@chrisbra
Copy link
Member

I mean, I know what they are (that is indeed one of the parts of code I hacked to remove the paths from the tab captions), but what would you suggest to have that custom formatter to do in order to solve this?

sure. I'll merge it, as it looks like you have finished transitioning this to github actions. If there need to be further actions, please open a new PR then.

Thanks, as always.

@chrisbra chrisbra merged commit 324797b into vim-airline:master Dec 17, 2020
@get-me-power get-me-power deleted the add_gha branch January 5, 2021 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants