🐛 Fix denops#server#deno variable name #371
Conversation
WalkthroughThe primary change involves adjusting the references to global variables in the Denops server scripts to enhance clarity and compatibility. Specifically, the global variable for the Deno runtime path has been renamed from Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Vim as Vim Script
participant DenopsServer as Denops Server
participant Deno as Deno Runtime
User->>Vim: Start Denops Server
Vim->>DenopsServer: Call s:start(options)
DenopsServer->>Vim: Update args with g:denops#server#deno
Vim->>Deno: Run with updated args
Deno-->>DenopsServer: Return execution result
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #371 +/- ##
=======================================
Coverage 90.23% 90.23%
=======================================
Files 9 9
Lines 676 676
Branches 64 64
=======================================
Hits 610 610
Misses 66 66 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- autoload/denops/_internal/server/proc.vim (1 hunks)
- autoload/denops/server.vim (1 hunks)
Additional comments not posted (2)
autoload/denops/_internal/server/proc.vim (1)
66-66: Variable name updated to match the intended configuration scope.The update from
g:denops#denotog:denops#server#denoin thes:startfunction is aligned with the PR's objective to ensure the correct variable is used. This change should help in maintaining consistency and clarity in variable usage across the project.Verification successful
Variable
g:denops#server#denois correctly initialized dynamically.The
denops#_internal#conf#definefunction ensures thatg:denops#server#denois initialized with a default value if it is not already set. This dynamic initialization guarantees that the variable is always defined.
autoload/denops/server.vim:call denops#_internal#conf#define('denops#server#deno', g:denops#deno)Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the initialization of `g:denops#server#deno`. # Test: Search for the initialization of `g:denops#server#deno`. Expect: At least one occurrence. rg --type vim $'let g:denops#server#deno ='Length of output: 44
Script:
#!/bin/bash # Description: Verify the initialization of `g:denops#server#deno` with different possible patterns. # Test 1: Search for direct initialization. rg --type vim $'let g:denops#server#deno' # Test 2: Search for initialization with a different scope or within a function. rg --type vim $'let s:denops#server#deno' rg --type vim $'let l:denops#server#deno' rg --type vim $'let b:denops#server#deno' # Test 3: Search for initialization using set command. rg --type vim $'set g:denops#server#deno' rg --type vim $'set s:denops#server#deno' rg --type vim $'set l:denops#server#deno' rg --type vim $'set b:denops#server#deno'Length of output: 343
Script:
#!/bin/bash # Description: Verify if `g:denops#server#deno` is mentioned or set dynamically in the codebase. # Test: Search for any mention of `denops#server#deno` in the codebase. rg --type vim 'denops#server#deno'Length of output: 393
Script:
#!/bin/bash # Description: Find the implementation of the function `denops#_internal#conf#define`. # Test: Search for the function definition of `denops#_internal#conf#define`. rg --type vim 'function! denops#_internal#conf#define'Length of output: 151
Script:
#!/bin/bash # Description: Extract the implementation of the function `denops#_internal#conf#define`. # Test: Get the implementation details of `denops#_internal#conf#define`. rg --type vim 'function! denops#_internal#conf#define' -A 20Length of output: 285
autoload/denops/server.vim (1)
150-150: Proper initialization of server-related settings.The addition of
denops#_internal#conf#definecalls to initialize server settings such asg:denops#server#denoensures that all configurations are properly set up. This is crucial for the correct operation of the server and helps in maintaining a consistent configuration state across the server lifecycle.
Close #369
Summary by CodeRabbit