Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review: Async.Promise #567

Merged
merged 20 commits into from
Jan 1, 2018
Merged

Review: Async.Promise #567

merged 20 commits into from
Jan 1, 2018

Commits on Dec 31, 2017

  1. Async.Promise: First implementation based on es6-promise

    @rhysd
    rhysd committed Dec 31, 2017
    Configuration menu
    Copy the full SHA
    dd78349 View commit details
    Browse the repository at this point in the history

  2. Async.Promise: Add tests for all APIs

    @rhysd
    rhysd committed Dec 31, 2017
    Configuration menu
    Copy the full SHA
    088e312 View commit details
    Browse the repository at this point in the history

  3. Async.Promise: Do not check self fulfillment 

    Discussion for ES6 Promise:
  promises-aplus/promises-spec#108

Standard ES6 Promise does not check self fulfillment. And in Vim script,
there is no way to refer itself in thenable object because Promise
object is copy of s:PROMISE.
    @rhysd
    rhysd committed Dec 31, 2017
    Configuration menu
    Copy the full SHA
    ad71bbe View commit details
    Browse the repository at this point in the history

  4. Async.Promise: Ensure fulfilled/rejected callbacks are asynchronously… 

    … called
    @rhysd
    rhysd committed Dec 31, 2017
    Configuration menu
    Copy the full SHA
    78a7476 View commit details
    Browse the repository at this point in the history

  5. Async.Promise: Fix tests for asynchronous fulfillment/rejection

    @rhysd
    rhysd committed Dec 31, 2017
    Configuration menu
    Copy the full SHA
    ba7d405 View commit details
    Browse the repository at this point in the history

  6. Async.Promise: Prefer partial to lambda 

    because it is usually shorter and faster. (As long as I measured,
partial is 10% faster than lambda when some variable is captured.
    @rhysd
    rhysd committed Dec 31, 2017
    Configuration menu
    Copy the full SHA
    1e82791 View commit details
    Browse the repository at this point in the history

  7. Async.Promise: Add a help document

    @rhysd
    rhysd committed Dec 31, 2017
    Configuration menu
    Copy the full SHA
    b0e9d8f View commit details
    Browse the repository at this point in the history

  8. Async.Promise: Fix maybe-uninitialized variable 

    Although previous code has no problem, but linter complains about it.
    @rhysd
    rhysd committed Dec 31, 2017
    Configuration menu
    Copy the full SHA
    fea1b27 View commit details
    Browse the repository at this point in the history

  9. Async.Promise: Prefer function to method

    @rhysd
    rhysd committed Dec 31, 2017
    Configuration menu
    Copy the full SHA
    264c07f View commit details
    Browse the repository at this point in the history

  10. Async.Promise: Fix job example in document 

    Thank you @lambdalisue and @tyru!
    @rhysd
    rhysd committed Dec 31, 2017
    Configuration menu
    Copy the full SHA
    f392520 View commit details
    Browse the repository at this point in the history

  11. Async.Promise: Explicit l: at :let to avoid functioin name conflicts 

    Thank you @haya14busa and @tyru!
    @rhysd
    rhysd committed Dec 31, 2017
    Configuration menu
    Copy the full SHA
    58041c4 View commit details
    Browse the repository at this point in the history

  12. Async.Promise: Give tags to examples and fix example codes 

    Thank you @tyru and @haya14busa!
    @rhysd
    rhysd committed Dec 31, 2017
    Configuration menu
    Copy the full SHA
    e956ca0 View commit details
    Browse the repository at this point in the history

  13. Async.Promise: Refactor state check in _publish() and wait_group in a… 

    …ll()
    @rhysd
    rhysd committed Dec 31, 2017
    Configuration menu
    Copy the full SHA
    057d36e View commit details
    Browse the repository at this point in the history

  14. Async.Promise: Check features rather than versions for availability

    @rhysd
    rhysd committed Dec 31, 2017
    Configuration menu
    Copy the full SHA
    cf1bd23 View commit details
    Browse the repository at this point in the history

  15. Async.Promise: Fix test descriptions and variable names, more checks 

    nit festival! Thank you @haya14busa
    @rhysd
    rhysd committed Dec 31, 2017
    Configuration menu
    Copy the full SHA
    427a0cd View commit details
    Browse the repository at this point in the history

  16. Async.Promise: Promise value is never settled in _subscribe()

    @rhysd
    rhysd committed Dec 31, 2017
    Configuration menu
    Copy the full SHA
    82b5c31 View commit details
    Browse the repository at this point in the history

  17. Async.Promise: Reject with dict when catching an exception

    @rhysd
    rhysd committed Dec 31, 2017
    Configuration menu
    Copy the full SHA
    e9770e2 View commit details
    Browse the repository at this point in the history

  18. Async.Promise: Fix/brush up the help document 

    thank you @thinca
    @rhysd
    rhysd committed Dec 31, 2017
    Configuration menu
    Copy the full SHA
    1095e9b View commit details
    Browse the repository at this point in the history

  19. Async.Promise: Use themis.vim v1.5.4

    @rhysd
    rhysd committed Dec 31, 2017
    Configuration menu
    Copy the full SHA
    b8770b7 View commit details
    Browse the repository at this point in the history

  20. Async.Promise: Prefer is v:null to == type(v:null)

    @rhysd
    rhysd committed Dec 31, 2017
    Configuration menu
    Copy the full SHA
    fbed16a View commit details
    Browse the repository at this point in the history