Add an autocommand to re-add highlight groups #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Friendly bump on this! @alerque or @fmoralesc I'd love if one of you two had a moment to take a look at this. Happy to make changes as needed. Thanks in advance. |
alerque
approved these changes
Nov 26, 2023
|
Sorry it took so long for this to hit my radar at a time when I had time to actually read it. It's an obvious win. Thanks for the contribution. |
|
No worries, thanks for the review and Happy Thanksgiving 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #211
Fixes #376
The relevant motivation and summary are in the comment that I've left behind in
the file.
I will mention that this technique is not uncommon:
https://github.com/search?q=%2Fautocmd+ColorScheme%2F&type=code
A similar pattern comes up in most other syntax files that define custom
highlighting groups.
Before
before.mov
After
after.mov