Feat prefix/suffix conversions #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atusy
commented
Jun 8, 2024
denops/skkeleton/function/input.ts
Outdated
Comment on lines
204
to
210
| // suffix | ||
| if (context.state.type == "henkan") { | ||
| await kakutei(context); | ||
| henkanPoint(context); | ||
| await acceptResult(context, [">", ""], ""); | ||
| return; | ||
| } |
There was a problem hiding this comment.
It might be better to move this to henkan.ts with a name suffix().
However, I did not do it at the moment because acceptResult() is not exported and I could not replace it with an exported kanaInput() function.
If we can split the function, I would also rename affix() to prefix().
There was a problem hiding this comment.
I simply haven't exported it because I don't use it anywhere else. It's okay to change export it.
atusy
commented
Jun 8, 2024
| context.state.henkanFeed.length > 0 && | ||
| ["okurinasi", "okuriari"].includes(context.state.mode) | ||
| ) { | ||
| await acceptResult(context, [">", ""], ""); |
There was a problem hiding this comment.
Ignoring user-kana-table by a direct use of acceptResult
No longer needed because it only mattered in my PoC
`affix()` is more robust thant `henkanFirst()` because `affix()` is `state.type`-aware. `henkanFirst()` may determine AffixType if it is undefined. However, the result might be wrong because prefix has higher priority than suffix.
|
Lint check is failed. Please fix. |
|
oops. I will |
|
lint error is fixed |
|
Thanks. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
>to enable the feature