fix: #10080

vimeo · Sep 25, 2023 · 082d43c · 082d43c
1 parent 7d8d74d
commit 082d43c
Showing 1 changed file with 14 additions and 1 deletion.
diff --git a/src/Psalm/Internal/Diff/ClassStatementsDiffer.php b/src/Psalm/Internal/Diff/ClassStatementsDiffer.php
@@ -6,6 +6,7 @@
 
 use function count;
 use function get_class;
+use function is_string;
 use function strpos;
 use function strtolower;
 use function substr;
@@ -230,7 +231,19 @@ static function (
                 /** @var PhpParser\Node */
                 $affected_elem = $diff_elem->type === DiffElem::TYPE_REMOVE ? $diff_elem->old : $diff_elem->new;
                 if ($affected_elem instanceof PhpParser\Node\Stmt\ClassMethod) {
-                    $add_or_delete[] = $name_lc . '::' . strtolower((string) $affected_elem->name);
+                    $name = strtolower((string) $affected_elem->name);
+                    $add_or_delete[] = $name_lc . '::' . $name;
+                    if ($name === '__construct') {
+                        foreach ($affected_elem->getParams() as $param) {
+                            if (!$param->flags
+                                || !$param->var instanceof PhpParser\Node\Expr\Variable
+                                || !is_string($param->var->name)
+                            ) {
+                                continue;
+                            }
+                            $add_or_delete[] = $name_lc . '::$' . $param->var->name;
+                        }
+                    }
                 } elseif ($affected_elem instanceof PhpParser\Node\Stmt\Property) {
                     foreach ($affected_elem->props as $prop) {
                         $add_or_delete[] = $name_lc . '::$' . $prop->name;