fix infinite loop bug in PHP 7

vimeo · Jun 6, 2023 · 1f913c8 · 1f913c8
1 parent 9318972
commit 1f913c8
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/Psalm/Internal/Provider/ReturnTypeProvider/SprintfReturnTypeProvider.php b/src/Psalm/Internal/Provider/ReturnTypeProvider/SprintfReturnTypeProvider.php
@@ -160,7 +160,11 @@ public static function getFunctionReturnType(FunctionReturnTypeProviderEvent $ev
                         break;
                     }
 
-                    array_pop($dummy);
+                    // for PHP 7, since it doesn't throw above
+                    // abort if it's empty, since we checked everything
+                    if (array_pop($dummy) === null) {
+                        break;
+                    }
                 }
 
                 if ($event->getFunctionId() === 'printf') {