Merge pull request #10488 from kkmuffme/invalidargument-false-not-tru…

…e-param add InvalidArgument error when passing false to true param
vimeo · Dec 13, 2023 · 3bc8cde · 3bc8cde
2 parents f7fe4cf + d04694f
commit 3bc8cde
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/Psalm/Internal/Analyzer/Statements/Expression/Call/ArgumentAnalyzer.php b/src/Psalm/Internal/Analyzer/Statements/Expression/Call/ArgumentAnalyzer.php
@@ -902,7 +902,7 @@ public static function verifyType(
             $input_type,
             $param_type,
             true,
-            true,
+            !isset($param_type->getAtomicTypes()['true']),
             $union_comparison_results,
         );
 

diff --git a/tests/FunctionCallTest.php b/tests/FunctionCallTest.php
@@ -2358,6 +2358,17 @@ function fooFoo(int $a): void {}
                     fooFoo("string");',
                 'error_message' => 'InvalidArgument',
             ],
+            'invalidArgumentFalseTrueExpected' => [
+                'code' => '<?php
+                    /**
+                     * @param true|string $arg
+                     * @return void
+                     */
+                    function foo($arg) {}
+
+                    foo(false);',
+                'error_message' => 'InvalidArgument',
+            ],
             'builtinFunctioninvalidArgumentWithWeakTypes' => [
                 'code' => '<?php
                     $s = substr(5, 4);',