Fix language server running with opcache.save_comments=0

Fixes #10353
vimeo · Jan 30, 2024 · 98756ba · 98756ba
1 parent f045730
commit 98756ba
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/src/Psalm/Internal/Fork/PsalmRestarter.php b/src/Psalm/Internal/Fork/PsalmRestarter.php
@@ -84,6 +84,11 @@ protected function requiresRestart($default): bool
             }
         }
 
+        // opcache.save_comments is required for json mapper (used in language server) to work
+        if ($opcache_loaded && in_array(ini_get('opcache.save_comments'), ['0', 'false', 0, false])) {
+            return true;
+        }
+
         return $default || $this->required;
     }
 
@@ -152,6 +157,10 @@ protected function restart($command): void
             ];
         }
 
+        if ($opcache_loaded) {
+            $additional_options[] = '-dopcache.save_comments=1';
+        }
+
         array_splice(
             $command,
             1,