Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Most magic methods are forbidden on enums #8889

Closed
weirdan opened this issue Dec 12, 2022 · 1 comment · Fixed by #8890
Closed

Most magic methods are forbidden on enums #8889

weirdan opened this issue Dec 12, 2022 · 1 comment · Fixed by #8890
Labels
enhancement enum

Comments

@weirdan
Copy link
Collaborator

weirdan commented Dec 12, 2022

@psalm-github-bot
Copy link

I found these snippets:

https://psalm.dev/r/cbe3d6be9b 
<?php
enum E {
    case A;
    case B;
    public function __wakeup() {}
}
Psalm output (using commit ef02ded):

No issues!

@weirdan weirdan mentioned this issue Dec 12, 2022
Merged
weirdan added a commit to weirdan/psalm that referenced this issue Dec 12, 2022
@weirdan
Forbid most magic methods on enums
19a1005 
Fixes vimeo#8889

Additionally this fixes case-sensitivity of
MethodSignatureMustOmitReturnType issue

Fixes vimeo#8888
weirdan added a commit that referenced this issue Dec 12, 2022
@weirdan
Merge pull request #8890 from weirdan/enum-forbidden-methods
fb685a1 
Fixes #8889
Fixes #8888
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement enum
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Forbid most magic methods on enums weirdan/psalm
1 participant
@weirdan